I definitely like white socks better than dark ones, especially if they are heavy white athletic socks. Of course you can't wear the white ones to work with your dark dress pants, so please die when you are off-duty.
I've never liked the kind of socks he's wearing, the delicate little ones that only cover the feet. If you don't want anyone to see your socks, why not just skip the socks altogether. I know they are very popular with guys, but what purpose do they serve?